fix: retrieving repoid through commit report can yield error #1132
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: upload/serializers.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 838 838
Lines 19775 19775
=======================================
Hits 18998 18998
Misses 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
fixes: https://github.com/codecov/internal-issues/issues/1208
fixes: https://github.com/codecov/internal-issues/issues/1209
Sometimes having trouble getting the repo_id via
upload.reportpath, showing a Commit Report does not exist error. Maybe some race condition where the commit report object is not committed to the DB yet. This change will just get the repo_id directly from the Repository object.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.